Make EffBroadcast calls BroadcastMessageEvent #5979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
enhancement
Pikachu920
reviewed
Sep 8, 2023
Fusezion
suggested changes
Sep 8, 2023
Comment on lines
+63
to
+64
| private static final Pattern HEX_PATTERN = Pattern.compile("(?i)&x((?:&\\p{XDigit}){6})"); | ||
|
|
There was a problem hiding this comment.
Would it be worth while making a public static final for this in Utils? we currently have this created in utils, raw string and now effect broadcast.
There was a problem hiding this comment.
I would love to honestly, but I'm afraid that such changes seems out of scope of this PR for the team. So I'll leave this as is.
Pikachu920
reviewed
Sep 8, 2023
Moderocky
approved these changes
Sep 9, 2023
Moderocky
force-pushed
the
master
branch
3 times, most recently
from
bd134d0
to
3f08853
Compare
sovdeeth
approved these changes
Apr 15, 2024
Moderocky
added
the
feature-ready
sovdeeth
requested changes
May 8, 2024
sovdeeth
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes EffBroadcast calls for BroadcastMessageEvent. This comment onwards has explained the reasons of why EffBroadcast is implemented in such ways.
JUnit tests can be added after Skript has support of listening to this event.
Target Minecraft Versions: any
Requirements: -
Related Issues: #5617