Add the variable case node instead of being hidden #5674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
added
the
enhancement
AyhamAl-Ali
approved these changes
May 5, 2023
Moderocky
force-pushed
the
master
branch
2 times, most recently
from
bd134d0
to
3f08853
Compare
Moderocky
approved these changes
Sep 17, 2023
Moderocky
added
the
feature-ready
|
Little note on this but it may be out-of-scope yet it's very related, for flexibility this shouldn't convert variables to lowercase when set to true INSTEAD it should do equalsIgnoreCase otherwise when toggling it on/off this will cause lots of issues as it does permanent damage/change. Adding to that, this PR doesn't really fix the mentioned issue, this only shows the option but the behavior is still as described above. |
TheLimeGlass
force-pushed
the
enhancement/variable-case
branch
from
2b33c36
to
07fa2f1
Compare
AyhamAl-Ali
approved these changes
Sep 27, 2023
Co-authored-by: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The configuration node
case-insensitive variables: trueis hidden, so this pull requests makes it not hidden. See related issue for a valid reasoning.Target Minecraft Versions: any
Requirements: none
Related Issues: #2163