Allow profilers to run #5550
Merged
Allow profilers to run #5550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
added
bug
Moderocky
force-pushed
the
master
branch
2 times, most recently
from
bd134d0
to
3f08853
Compare
Moderocky
approved these changes
Sep 18, 2023
sovdeeth
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables the timeout of the test runner when the profiler is set. The server should complete the process or it's the responsibility of most profilers to terminate the process after they've done their processing by Java standards.
Most profilers have a prompt to notify the user that it's complete.
Solution to this is to add a timeout parameter as all the profiler arguments are done via gradle, whereas the timeout is done on the test runner side PlatformMain application.