Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add damage support for PlayerItemDamageEvent #5269

Closed
wants to merge 11 commits into from

Conversation

TheLimeGlass
Copy link
Collaborator

@TheLimeGlass TheLimeGlass commented Dec 24, 2022

Description

  • Adds damage support for the PlayerItemDamageEvent event.
  • Moves the cannot be changed messages into ChangerUtils for API compatibility.

Target Minecraft Versions: 1.14+
Requirements: Paper 1.18+ for original damage
Related Issues: #5258

@TheLimeGlass TheLimeGlass added the feature Pull request adding a new feature. label Dec 24, 2022
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
Co-authored-by: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
@Moderocky Moderocky changed the base branch from master to dev/feature September 18, 2023 09:56
@sovdeeth
Copy link
Member

sovdeeth commented Dec 30, 2023

Implemented by #5678, it seems.

If there are changes here that are substantial additions to what 5678 added that you'd still like to pursue, please re-open this!

@sovdeeth sovdeeth closed this Dec 30, 2023
@APickledWalrus APickledWalrus deleted the feature/item-event-damage branch February 5, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants