-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Item cooldown expression + condition #4198
🚀 Item cooldown expression + condition #4198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this one 👍
Just some things to go over:
src/main/java/ch/njol/skript/conditions/CondItemHasCooldown.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondItemHasCooldown.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondItemHasCooldown.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondItemHasCooldown.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple things
src/main/java/ch/njol/skript/conditions/CondHasItemCooldown.java
Outdated
Show resolved
Hide resolved
Co-authored-by: APickledWalrus <apickledwalrus@gmail.com>
Co-authored-by: APickledWalrus <apickledwalrus@gmail.com>
Co-authored-by: APickledWalrus <apickledwalrus@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should just be these two final things
src/main/java/ch/njol/skript/conditions/CondHasItemCooldown.java
Outdated
Show resolved
Hide resolved
Co-authored-by: APickledWalrus <apickledwalrus@gmail.com>
Co-authored-by: APickledWalrus <apickledwalrus@gmail.com>
src/main/java/ch/njol/skript/conditions/CondHasItemCooldown.java
Outdated
Show resolved
Hide resolved
Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>
src/main/java/ch/njol/skript/conditions/CondHasItemCooldown.java
Outdated
Show resolved
Hide resolved
- Handle IAE for materials - Handle CCE caused by wrong expression choice - Change HumanEntity to Player
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
src/main/java/ch/njol/skript/conditions/CondHasItemCooldown.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondHasItemCooldown.java
Outdated
Show resolved
Hide resolved
Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>
src/main/java/ch/njol/skript/conditions/CondHasItemCooldown.java
Outdated
Show resolved
Hide resolved
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Description
This PR aims to add the ability to check if a specific material of specific players has cooldown or not and adds the ability to get, set and delete/reset that cooldown.
Target Minecraft Versions: 1.12+
Requirements: Minecraft 1.12+
Related Issues: #3986