-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better StackOverflowError Handling #3195
Better StackOverflowError Handling #3195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
We should probably wait to hear feedback from the others, but I think it seems good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought aliases parsing was the one causing the pattern errors, is it not the case?
Oops, my bad. I'll move the try-catch |
Description
This PR adds a warning to users attempting to run Skript with 32-bit Java, in addition a proper Skript error message if users encounter a StackOverflowError when loading scripts at the plugin enable phase.
Target Minecraft Versions: Any
Requirements: None
Related Issues: #2752