Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/inventory issue #3180

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Fix/inventory issue #3180

merged 2 commits into from
Jul 20, 2020

Conversation

ShaneBeee
Copy link
Contributor

Description

Fix inventory showing wrong type when using "show" effect instead of "open"
Re-arranged the numbers as well to keep the order making sense.

Target Minecraft Versions: all
Requirements: none
Related Issues: #3096

@ShaneBeee ShaneBeee added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jul 20, 2020
Wealthyturtle
Wealthyturtle approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@Wealthyturtle Wealthyturtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wealthyturtle Wealthyturtle merged commit 43ca0dd into SkriptLang:master Jul 20, 2020
@ShaneBeee ShaneBeee deleted the fix/inventory-issue branch July 20, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wealthyturtle Wealthyturtle Wealthyturtle approved these changes

Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaneBeee @Wealthyturtle