Time Since Expression #2907
Merged
Time Since Expression #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pikachu920
requested changes
Apr 5, 2020
|
Okay I made some changes. Hopefully everything should be good now! Edit: I forgot to fix the test... woops. If there are any other issues I'll fix them with that commit |
Pikachu920
previously requested changes
Apr 18, 2020
src/main/java/ch/njol/skript/expressions/ExprLastDeathTime.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprLastDeathTime.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprLastDeathTime.java
Outdated
Show resolved
Hide resolved
|
Looks like there may have been some issues while running the test? Everything worked fine on my end when I ran it. Edit: Had it rerun - everything is good now. |
It was decided that ExprLastDeathTime should just be handled in a to-be-made ExprStatistic
APickledWalrus
changed the title
|
This PR is now just going to add ExprTimeSince (see the commit message). |
FranKusmiruk
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
an expression that returns the date of a player's last death.This also addsa 'time since %dates%' expression that has the same functionality as using 'now' and a date with the difference between expression, but in a more user friendly form.Some may disagree with my choice to have the player's last death expression return the date of the death, while the actual statistic I'm using returns the time since the player's last death. I would like to hear opinions on this, and possibly make changes.Target Minecraft Versions: Any
Requirements: None
Related Issues: #2905 (kind of)