Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkriptError - add addon version #2588

Merged
merged 4 commits into from
Nov 4, 2019
Merged

SkriptError - add addon version #2588

merged 4 commits into from
Nov 4, 2019

Conversation

ShaneBeee
Copy link
Contributor

Description

This PR is to add the version of the addons to Skript's sever error messages.

Many times when helping people, they will send a stack trace error. Often times these errors are created by addons, but seeing something like this:

[14:13:50 ERROR]: #!#! Here is full list of them:
[14:13:50 ERROR]: #!#! skript-mirror (https://github.com/btk5h/skript-mirror) TuSKe (github.com/Tuke-Nuke/TuSKe) SK-NBeeT (https://github.com/ShaneBeee/Sk-NBeeT) 

...is not helpful, as we have no clue which versions of the addons the user is using. Quite often we ask "Which version of Tuske are you using", reply: "latest" or "newest" and more often than not, they are not using the "latest" or "newest" version of said addon.

Simply adding the version to the error, we can cut down on asking which version of the addon they are using, ex:

[14:06:49 ERROR]: #!#! Here is full list of them:
[14:06:49 ERROR]: #!#! skript-mirror-2.0.0-SNAPSHOT (https://github.com/btk5h/skript-mirror) TuSKe-1.8.2-Pikachu-Patch-3 (github.com/Tuke-Nuke/TuSKe) SK-NBeeT-2.7.2 (https://github.com/ShaneBeee/Sk-NBeeT) 

Now by being able to see the version of the addon they are using, we can offer better/quicker support, such as "You should update skript-mirror to 2.0.0" or "You should use Pikachu's patch of Tuske"


Target Minecraft Versions: any
Requirements: none
Related Issues: none

- Add version to addon
@Wealthyturtle Wealthyturtle added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Oct 22, 2019
- Shortened everything down to getFullName
- Changed to getFullName
@bensku bensku merged commit ac2a62c into SkriptLang:master Nov 4, 2019
@ShaneBeee ShaneBeee deleted the feature/addon-version branch August 6, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants