ExprExplodedBlocks - new #2511
Merged
ExprExplodedBlocks - new #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/ch/njol/skript/expressions/ExprExplodedBlocks.java
Outdated
Show resolved
Hide resolved
- Split up examples onto separate lines
|
Huh, I've done this myself yesterday, I just didn't push it |
Pikachu920
reviewed
Oct 11, 2019
Pikachu920
reviewed
Oct 11, 2019
src/main/java/ch/njol/skript/expressions/ExprExplodedBlocks.java
Outdated
Show resolved
Hide resolved
bensku
requested changes
Oct 21, 2019
src/main/java/ch/njol/skript/expressions/ExprExplodedBlocks.java
Outdated
Show resolved
Hide resolved
- Remove "destroyed" from pattern to cut down confusion with break events
|
There should be a way to prevent explosion of specific blocks SkQuery does it like loop exploded blocks:
if .. :
remove loop-block from exploded blocksshould also support item types like |
There was a problem hiding this comment.
The expression itself is fine right now but it can be improved, you may consider the following:
- Implementing ItemType changers to the expression as Blueyescat suggested.
- Implementing the iterator method since the main usage of the expression is looping.
- Support the EntityExplodeEvent, even if we don't support this event right now, being future-proof isn't bad.
|
We can improve the expression later. This is much better than nothing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an expression to retrieve the exploded blocks from an explosion event
Target Minecraft Versions: any
Requirements: none
Related Issues: #2509