Add EffDoIf

[OfficialDonut]

Target Minecraft versions: any
Requirements: none
Related issues: none

Description:
This executes an effect if a condition is true. The syntax is [(do|execute)] <.+> if <.+> where the first regex is an effect and the second is the condition.
Ex:

on join:
	give diamond to player if player has permission "rank.vip"

Standalone this effect does not conflict with ternaries but if a ternary is used within the effect parenthesis must be used:

#invalid
give diamond if {diamond::%player%} is true else emerald to player if player has permission "rank.vip"

#valid
give (diamond if {diamond::%player%} is true else emerald) to player if player has permission "rank.vip"

[Blueyescat]

Nice idea! I was thinking about this lol.

I think [(do|execute)] should be removed because it would look ugly and doesn't make sense because this is not something like evaluate %string%.

execute stop
do ban the player
execute execute player command ""
do make player ride target

Also what happens if you nest do ifs?

stop if {_x} set if {_y} is not set
(stop if {_x} set) if {_y} is not set

Both shouldn't work since it uses regex and already it shoudn't work i think.

[OfficialDonut]

Yeah I agree the do/execute part doesn't sound very good and yeah nested ifs don't work

[Pikachu920]

I'm not sure if I like this idea, it's not like the alternative is much harder to write. The parser is already not so good at handling long lines.

A couple of things ignoring my concerns:

1. The code won't compile using ECJ
2. These shouldn't be nestable

[OfficialDonut]

they're not nestable

[Pikachu920]

I don't see where in the code you enforce that

[OfficialDonut]

it doesn't work
do (do set {test} to 1 if 1 is 1) if 1 is 1
is there a case where it does?

[Pikachu920]

you shouldn't just rely on the parser being dumb, though... best to check in init

[Blueyescat]

@Pikachu920 The parser will read the code from the right and it uses regex

So when you use set {test} to 0 if 1 is 1 if 2 is 2
set {test} to 0 will be the DO
1 is 1 if 2 is 2 will be the IF (which is a wrong condition and will error)

And in this case you can't understand if the first regex is also a Do If effect.

---

BTW (set {test} to 1 if 1 is 1) if 1 is 1 is not right, you can't use parenthesis around a regex.

[OfficialDonut]

Pikachu is right it doesn't hurt to guarantee it

[Blueyescat]

That change won't affect anything.

[TheLimeGlass]

Define what you're changing in the title of the git commit, rather than just Update EffDoIf.java

After the if there should be support for all genders and nouns that Skript already supports in syntax. Test to make sure it does this already from the expressions. If not that will need to be added.

Examples:

teleport player to the target entity if the target entity is a sheep
set target block to light green stained glass if a lamp is above the player

Also have you tested if time states work?

on fade:
    cancel event if the block was ice

In my opinion I like IIF/ternary better but both are grammatically correct for an English based scripting language.

on fade:
    if the block was ice cancel the event

[Blueyescat]

@TheLimeGlass Your examples will work the same since he didn't make his own parser.

[Nicofisi]

Also have you tested if time states work?

on fade:
cancel event if the block was ice

@TheLimeGlass this wouldn't even work when used normally already, #671

[TheLimeGlass]

Then fix it

[Misio12320]

When this will be added?

[Romitou]

When this will be added?

It's already added.

[ShaneBeee]

When this will be added?

As you can see by the purple "Merged" ... that means it's been added. It was actually added back in 2.3
http://skriptlang.github.io/Skript/effects.html#EffDoIf

[Misio12320]

Yes. Okay so merged = closed + added now I understand. And what the red is Travis fixes, forgot import, and fixed eff not working?