Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation generator syntax pattern bug #4072

Closed
TPGamesNL opened this issue Jun 15, 2021 · 0 comments
Closed

Documentation generator syntax pattern bug #4072

TPGamesNL opened this issue Jun 15, 2021 · 0 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. documentation Related to Skript's official documentation. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@TPGamesNL
Copy link
Member

TPGamesNL commented Jun 15, 2021 •
edited
Loading

In a group part of a pattern, an empty group is not included properly in the documentation:

Skript/src/main/java/ch/njol/skript/effects/EffVehicle.java

Line 50 in 9547172

"(eject|dismount) (any|the|) passenger[s] (of|from) %entities%");

(notice (any|the|))
image
The last | is removed on the docs, and probably should have been replaced with an optional group surrounding it (since (any|the|) is equal to [(any|the)]), but this replacement is done incorrectly, as the first [ is placed in the wrong position, in this case at the start of the pattern instead of right before the group.

Related: #4011
@TPGamesNL TPGamesNL added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. documentation Related to Skript's official documentation. labels Jun 15, 2021
AyhamAl-Ali added a commit to AyhamAl-Ali/Skript that referenced this issue Jul 6, 2021
@AyhamAl-Ali
Multiple fixes
dcb47a1 
- General Improvements (responsivity)
- Improved mobile view (responsivity)
- Fixed cleanPattern (SkriptLang#4072 SkriptLang#4011)
- Fixed <code> and <pre> fonts
- Fixed ExprAmount Description
- Fixed mobile anchors
@AyhamAl-Ali AyhamAl-Ali mentioned this issue Jul 6, 2021
Merged
@APickledWalrus APickledWalrus added the PR available Issues which have a yet-to-be merged PR resolving it label Jul 16, 2021
@TPGamesNL TPGamesNL added PR available Issues which have a yet-to-be merged PR resolving it and removed PR available Issues which have a yet-to-be merged PR resolving it labels Jul 31, 2021
@APickledWalrus APickledWalrus added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. documentation Related to Skript's official documentation. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@APickledWalrus @TPGamesNL