Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExprBlocksInRegion is including blocks outside of the region. #2617

Closed
APickledWalrus opened this issue Nov 3, 2019 · 0 comments
Closed
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@APickledWalrus
Copy link
Member

Description

When trying to set all of the blocks in a region, blocks outside of the region are also updated.
Based on the bounds below, I think it is related to the 1 being added here:

new Vector(max.getBlockX() + 1, max.getBlockY() + 1, max.getBlockZ() + 1)).iterator();

Steps to Reproduce

Region Bounds: 30, 64, -2 TO 30, 67, -1
Updated Blocks Bounds: 30, 64, -2, TO 31, 68, 0

options:
    world: world
    corner1.x: 30.5
    corner1.y: 67.0
    corner1.z: -1.5

set {_corner1} to location at {@corner1.x}, {@corner1.y}, {@corner1.z} of the world world("{@world}")
set all blocks in the region (region at {_corner1}) to loop-value-2

Expected Behavior

Only the blocks in the region should be set.

Server Information

  • Server version/platform: git-Paper-225 (MC: 1.14.4) (Latest Version of Paper)
  • Skript version: 2.4-beta9

Additional Context

I will probably open a pull request fixing this issue soon.

@Wealthyturtle Wealthyturtle added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Nov 4, 2019
@bensku bensku added the completed The issue has been fully resolved and the change will be in the next Skript update. label Nov 11, 2019
bensku added a commit that referenced this issue Nov 11, 2019
@bensku bensku closed this as completed Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

3 participants