Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All potions are water #2581

Closed
bluelhf opened this issue Oct 19, 2019 · 1 comment
Closed

All potions are water #2581

bluelhf opened this issue Oct 19, 2019 · 1 comment
Assignees
@bensku
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@bluelhf
Copy link
Contributor

bluelhf commented Oct 19, 2019

Description

All potions default to either water bottles or mundane potions since beta9

Steps to Reproduce

Use Skript 2.4-beta9
Try giving yourself any potion
See result

Expected Behavior

You should be given the right potion without any issue.

Errors / Screenshots

img

Server Information

  • Server version/platform: git-Paper-219 (MC 1.14.4)
  • Skript version: 2.4-beta9
@ShaneBeee ShaneBeee added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Oct 19, 2019
@ShaneBeee
Copy link
Contributor

I can confirm this.

@bensku bensku self-assigned this Oct 21, 2019
bensku added a commit that referenced this issue Oct 21, 2019
@bensku
Fix potion comparison issues in aliases (#2581)
c844c54
@bensku bensku changed the title Potion aliases broke between beta7 and beta9 All potions are water Oct 21, 2019
@bensku bensku added the completed The issue has been fully resolved and the change will be in the next Skript update. label Oct 21, 2019
@bensku bensku mentioned this issue Oct 21, 2019
Closed
bensku added a commit that referenced this issue Oct 21, 2019
@bensku
Regtest for #2581
666e290
@bensku bensku closed this as completed Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bensku bensku

Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bensku @ShaneBeee @bluelhf