Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projectile comparison not functioning correctly #2286

Closed
sjoerdtim opened this issue Jul 22, 2019 · 2 comments
Closed

Projectile comparison not functioning correctly #2286

sjoerdtim opened this issue Jul 22, 2019 · 2 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@sjoerdtim
Copy link

sjoerdtim commented Jul 22, 2019 •
edited
Loading

Description

When you try to compare a projectile in a on projectile hit event, it doesn't work unless you parse both as string.

Steps to Reproduce

on projectile hit:
	projectile is snowball:
		broadcast "Doesn't work!"
	projectile is a snowball:
		broadcast "Doesn't work!"
	"%projectile%" is "snowball":
		broadcast "Works!"

Expected Behavior

Expected behavior would be that all three of these conditions result in true.

Server Information

  • Server version/platform: Paper version git-Paper-639 (MC 1.13.2) (Implementing API version 1.13.2-R0.1-SNAPSHOT)
  • Skript version: Skript version 2.4-beta3

Additional Context

I have only tested this with snowballs.
@bensku bensku added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Aug 4, 2019
@HAHAYOUDEAD
Copy link

same issue with (all?) other projectiles on 1.14.4 paper

tried with arrow, egg and ender pearl

@Wealthyturtle Wealthyturtle mentioned this issue Nov 1, 2019
Closed
@ShaneBeee ShaneBeee mentioned this issue Nov 9, 2019
Closed
@ShaneBeee
Copy link
Contributor

Closing this in favour of #2637
There are many issues on the tracker all stemming from this one big issue, so I wanted to condense this into one larger issue.

bensku added a commit that referenced this issue Dec 22, 2019
@bensku
Fix projectile comparisons (#2213, #2286)
c656546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bensku @sjoerdtim @ShaneBeee @HAHAYOUDEAD