-
-
Notifications
You must be signed in to change notification settings - Fork 368
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix force fly effect throwing exception when player wasn't allowed to…
… fly
- Loading branch information
1 parent
b10cbd6
commit cba6552
Showing
1 changed file
with
34 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cba6552
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line these up, and add the fly[ing] optional to the other second syntax, or the first and second syntax should be merged.
cba6552
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make player start fly
isn't proper grammar.cba6552
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noo, the user won't know that they has to disallow flight later.
cba6552
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be unfortunate. Kind of exploitable issue in survival servers.
cba6552
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I disallow it after setting fly or just a documentation change?
cba6552
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation change should be enough.
cba6552
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm.. I know stuff like that is supposed to be simple in Skript, but on the java/practical side,
setAllowFlight
andsetFlying
are two completely different things and should be split into two separate effects imocba6552
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forcing something to fly should be always possible. It is unfortunate that Minecraft separate forced flight from normal, creative flight.
cba6552
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
is a good idea if it wouldn't cause a problem 🤔