Add search feature #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
August 7, 2023 19:22
|
@lucianghinda have a look and on that too https://github.com/ShortRuby/rubyandrails.info/issues/23#issuecomment-1682892929 |
|
@obaidashfaq20 I am sorry for the delay in reviewing and merging this. I am in a vacation and will manage to review this next week. |
lucianghinda
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
@obaidashfaq20 Thank you for this PR. It looks good to be merged.
I have some improvements that need to be done, but they are related to the general structure of the project, so I don't want to keep this PR based on those.
I will merge this and then do myself a small PR to improve a bit the view of the search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress!
Description to be added