[Top Bar Feature] Remove all references to dynamicTopBarAndReframe feature
#12359
+77
−364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcthms
force-pushed
the
mrcthms-remove-top-bar-beta-flag-code
branch
from
d67efe2
to
6d62d85
Compare
|
/snapit |
|
🫰✨ Thanks @mrcthms! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20240712141617" |
|
/snapit |
|
🫰✨ Thanks @mrcthms! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20240712161118" |
laurkim
reviewed
Jul 12, 2024
| @@ -404,17 +348,6 @@ class FrameInner extends PureComponent<CombinedProps, State> { | |||
| ); | |||
| }; | |||
|
|
|||
| private setBodyStyles = () => { | |||
There was a problem hiding this comment.
I think this function is still needed for the conditionals that aren't checking for dynamicTopBarAndReframe, i.e., lines 408-410 and 414.
There was a problem hiding this comment.
Oh no you're right, I just looked at the PR where the function was being added and looks like it's safe to remove 👍
laurkim
approved these changes
Jul 15, 2024
Merged
alex-page
pushed a commit
that referenced
this pull request
Jul 22, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@9.3.0 ### Minor Changes - [#12233](#12233) [`491cf8038`](491cf80) Thanks [@ngkay](https://github.com/ngkay)! - Adds new icons for Shopify Finance ## @shopify/polaris@13.8.0 ### Minor Changes - [#12359](#12359) [`8f0f1b7e0`](8f0f1b7) Thanks [@mrcthms](https://github.com/mrcthms)! - Removed all references to the dynamicTopBarAndReframe feature and revert functionality back to how it was ### Patch Changes - Updated dependencies \[[`491cf8038`](491cf80)]: - @shopify/polaris-icons@9.3.0 ## polaris.shopify.com@1.0.11 ### Patch Changes - Updated dependencies \[[`8f0f1b7e0`](8f0f1b7), [`491cf8038`](491cf80)]: - @shopify/polaris@13.8.0 - @shopify/polaris-icons@9.3.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/polaris-internal/issues/481
As part of the clean up around the dynamicTopBarAndReframe cleanup, we want to revert all updates for this feature within
@shopify/polarisback to its initial state.WHAT is this pull request doing?
Remove all references to code changes around the
dynamicTopBarAndReframeand ensure behaviour is reverted back to how it was before the feature was introduced.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Flow sandbox with snapshot: https://flow.polaris-top-bar-test.marc-thomas.eu.spin.dev/dev-sandbox/overview/0190a740-3aad-7a63-a48b-30c3578f9a83
🎩 checklist
README.mdwith documentation changes