-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Icons] Add icons for image editing #11816
Conversation
…teLeft, RotateRight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason all the icon names start with a !
?
Because I forgot to remove it 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dGoligorsky is there any urgency to ship this? Trying to balance a couple of icon changes. Happy to get this through but just wanted to check first. |
@heyjoethomas ack... fixed 👍 Thanks for that. @alex-page I'll ping you with deets since this is a public repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few changes needed:
- For the
name
property, use sentence case (RemoveBackground
->Remove background
) - Remove
clip-path
attribute from SVGs - Add the
Icon
suffix to the.svg
filenames (FlipVertical.svg
->FlipVerticalIcon.svg
)
Happy to hep with any of these changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @dGoligorsky
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@8.10.0 ### Minor Changes - [#11816](#11816) [`4b730c84d`](4b730c8) Thanks [@dGoligorsky](https://github.com/dGoligorsky)! - Added some icons for image editing ### Patch Changes - [#11825](#11825) [`fd5b31d59`](fd5b31d) Thanks [@ryanwilsonperkin](https://github.com/ryanwilsonperkin)! - Add missing peer dependency on React ## @shopify/polaris@12.26.0 ### Minor Changes - [#11785](#11785) [`2a2f635ba`](2a2f635) Thanks [@mrcthms](https://github.com/mrcthms)! - Added the `defaultPaginatedSelectAllText` prop to `IndexTable` to support customizing the label of the checkbox in the header that selects all rows across pages when the table `hasMoreItems` ### Patch Changes - [#11833](#11833) [`810532c58`](810532c) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Revert responsive text style updates - [#11810](#11810) [`66dc0392a`](66dc039) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed Shift + click selection of `IndexTable.Row` not working in Firefox - [#11811](#11811) [`9aea67322`](9aea673) Thanks [@lgriffee](https://github.com/lgriffee)! - Undeprecated `heading2xl` variant in `Text` component - [#11817](#11817) [`936765c92`](936765c) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - [IndexTable] Initially hide the scrollbar and update scrollbar padding - [#11819](#11819) [`35eb10c4f`](35eb10c) Thanks [@kyledurand](https://github.com/kyledurand)! - Added multi select functionality to AlphaPicker - Updated dependencies \[[`fd5b31d59`](fd5b31d), [`4b730c84d`](4b730c8)]: - @shopify/polaris-icons@8.10.0 ## @shopify/polaris-migrator@0.28.6 ### Patch Changes - [#11813](#11813) [`c49809998`](c498099) Thanks [@lgriffee](https://github.com/lgriffee)! - Removed `Text` `heading2xl` and associated tokens from v14 font migration ## polaris.shopify.com@0.67.2 ### Patch Changes - [#11796](#11796) [`c8dc01330`](c8dc013) Thanks [@sarahill](https://github.com/sarahill)! - Updated common action pattern guidance - [#11811](#11811) [`9aea67322`](9aea673) Thanks [@lgriffee](https://github.com/lgriffee)! - Undeprecated `heading2xl` variant in `Text` component - Updated dependencies \[[`fd5b31d59`](fd5b31d), [`810532c58`](810532c), [`66dc0392a`](66dc039), [`9aea67322`](9aea673), [`4b730c84d`](4b730c8), [`2a2f635ba`](2a2f635), [`936765c92`](936765c), [`35eb10c4f`](35eb10c)]: - @shopify/polaris-icons@8.10.0 - @shopify/polaris@12.26.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
### WHY are these changes introduced? Some icons in use on image editing features are hardcoded svgs. This change introduces Polaris icons for `Crop`, `FlipHorizontal`, `FlipVertical`, `ImageMagic`, `RotateteLeft`, `RotateRight`. This not only allows the icons to exist in Polaris for web, but also allows them to get the Mobile icon size scaling. ### WHAT is this pull request doing? ![image](https://github.com/Shopify/polaris/assets/5823560/3d5f1f41-3d8e-4950-b429-dd220088f7bd) --------- Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
WHY are these changes introduced?
Some icons in use on image editing features are hardcoded svgs.
This change introduces Polaris icons for
Crop
,FlipHorizontal
,FlipVertical
,ImageMagic
,RotateteLeft
,RotateRight
.This not only allows the icons to exist in Polaris for web, but also allows them to get the Mobile icon size scaling.
WHAT is this pull request doing?