Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon] Add PersonSegment #11778

Merged
merged 4 commits into from
Mar 22, 2024
Merged

[Icon] Add PersonSegment #11778

merged 4 commits into from
Mar 22, 2024

Conversation

heyjoethomas
Copy link
Contributor

WHY are these changes introduced?

Adds PersonSegment icon for Customer Segments

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

@heyjoethomas heyjoethomas self-assigned this Mar 22, 2024
@heyjoethomas heyjoethomas added the Icon Polaris iconography label Mar 22, 2024
@heyjoethomas heyjoethomas marked this pull request as ready for review March 22, 2024 19:39
Copy link
Member

@sam-b-rose sam-b-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just had a few formatting and case convention suggestions.

polaris-icons/icons/PersonSegmentIcon.yml Outdated Show resolved Hide resolved
polaris-icons/icons/PersonSegmentIcon.yml Outdated Show resolved Hide resolved
.changeset/sixty-sheep-double.md Outdated Show resolved Hide resolved
heyjoethomas and others added 3 commits March 22, 2024 14:53
Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
@alex-page
Copy link
Member

I will need a 16x16 variant for https://github.com/Shopify/admin-ui-foundations/tree/main/admin-ui-icons

@heyjoethomas heyjoethomas merged commit d689bd8 into main Mar 22, 2024
9 checks passed
@heyjoethomas heyjoethomas deleted the person-segment-icon branch March 22, 2024 21:03
sophschneider pushed a commit that referenced this pull request Mar 26, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@8.9.0

### Minor Changes

- [#11778](#11778)
[`d689bd8f4`](d689bd8)
Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Added
`PersonSegment` icon

## @shopify/polaris@12.23.0

### Minor Changes

- [#11764](#11764)
[`880f31b44`](880f31b)
Thanks [@itwasmattgregg](https://github.com/itwasmattgregg)! - Added
align property for FooterHelp


- [#11691](#11691)
[`1e613de8b`](1e613de)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - - Added
`ThemeProvider` component
- Removed `html` from theme classes to remove global theme constraint
    -   Updated `useTheme` to be context aware of parent themes
    -   Updated `Portal` component to be context aware of parent themes
    -   Initialized a `dark-experimental` theme


- [#11787](#11787)
[`c3aefafe2`](c3aefaf)
Thanks [@chloerice](https://github.com/chloerice)! - Added support for
destructive `promotodBulkActions` to `BulkActions`

### Patch Changes

- Updated dependencies
\[[`1e613de8b`](1e613de),
[`d689bd8f4`](d689bd8)]:
    -   @shopify/polaris-tokens@8.9.0
    -   @shopify/polaris-icons@8.9.0

## @shopify/polaris-tokens@8.9.0

### Minor Changes

- [#11691](#11691)
[`1e613de8b`](1e613de)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - - Added
`ThemeProvider` component
- Removed `html` from theme classes to remove global theme constraint
    -   Updated `useTheme` to be context aware of parent themes
    -   Updated `Portal` component to be context aware of parent themes
    -   Initialized a `dark-experimental` theme

## @shopify/polaris-migrator@0.28.3

### Patch Changes

- Updated dependencies
\[[`1e613de8b`](1e613de)]:
    -   @shopify/polaris-tokens@8.9.0
    -   @shopify/stylelint-polaris@15.4.1

## @shopify/stylelint-polaris@15.4.1

### Patch Changes

- Updated dependencies
\[[`1e613de8b`](1e613de)]:
    -   @shopify/polaris-tokens@8.9.0

## polaris-for-vscode@0.9.7

### Patch Changes

- Updated dependencies
\[[`1e613de8b`](1e613de)]:
    -   @shopify/polaris-tokens@8.9.0

## polaris.shopify.com@0.66.2

### Patch Changes

- [#11776](#11776)
[`ca8eb99ea`](ca8eb99)
Thanks [@sarahill](https://github.com/sarahill)! - Updated common action
patterns example

- Updated dependencies
\[[`880f31b44`](880f31b),
[`1e613de8b`](1e613de),
[`d689bd8f4`](d689bd8),
[`c3aefafe2`](c3aefaf)]:
    -   @shopify/polaris@12.23.0
    -   @shopify/polaris-tokens@8.9.0
    -   @shopify/polaris-icons@8.9.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
### WHY are these changes introduced?

Adds `PersonSegment` icon for Customer Segments

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [ ] Tested a
[snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases)
- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

---------

Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Icon Polaris iconography
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants