-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chloe/oa dropzone keyboardevents #11713
base: oa-dropzone-keyboardevents
Are you sure you want to change the base?
Chloe/oa dropzone keyboardevents #11713
Conversation
@@ -72,8 +76,8 @@ export function WithALabel() { | |||
} | |||
|
|||
export function WithImageFileUpload() { | |||
const [files, setFiles] = useState([]); | |||
const [rejectedFiles, setRejectedFiles] = useState([]); | |||
const [files, setFiles] = useState<File[]>([]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(FIxed type errors throughout the file in addition to making the new story fully functional)
onClick={handleModalToggle} | ||
onDrop={handleThumbnailDrop} | ||
> | ||
<UnstyledButton style={thumbnailStyle} onKeyUp={handleKeypress}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interactive child should probably be configured to handle click event instead of the DropZone's wrapper div)
6d8b5bd
to
a0e6f77
Compare
7b336b6
to
5df6c82
Compare
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.md
with documentation changes