Polaris v12 border migration #10596
Merged
Polaris v12 border migration #10596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-b-rose
force-pushed
the
polaris-v12-border-migration
branch
from
987b9c3
to
3969936
Compare
Merged
lgriffee
reviewed
Sep 21, 2023
| @@ -165,7 +165,7 @@ | |||
| } | |||
|
|
|||
| // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY | |||
| @include focus-ring($border-width: var(--p-border-width-2)); | |||
| @include focus-ring($border-width: var(--p-border-width-0165)); | |||
There was a problem hiding this comment.
Suggested change
| @include focus-ring($border-width: var(--p-border-width-0165)); | |
| @include focus-ring($border-width: var(--p-border-width-050)); |
--p-border-width-2 should be replaced with --p-border-width-050 here.
lgriffee
reviewed
Sep 21, 2023
| @@ -60,7 +60,7 @@ | |||
| width: 100%; | |||
| height: 100%; | |||
| // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY | |||
| @include focus-ring($border-width: var(--p-border-width-2)); | |||
| @include focus-ring($border-width: var(--p-border-width-0165)); | |||
There was a problem hiding this comment.
Suggested change
| @include focus-ring($border-width: var(--p-border-width-0165)); | |
| @include focus-ring($border-width: var(--p-border-width-050)); |
--p-border-width-2 should be replaced with --p-border-width-050 here.
lgriffee
reviewed
Sep 21, 2023
| @@ -142,13 +142,12 @@ | |||
| width: 100%; | |||
| height: 100%; | |||
| // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY | |||
| @include focus-ring($border-width: var(--p-border-width-2)); | |||
| @include focus-ring($border-width: var(--p-border-width-0165)); | |||
There was a problem hiding this comment.
Suggested change
| @include focus-ring($border-width: var(--p-border-width-0165)); | |
| @include focus-ring($border-width: var(--p-border-width-050)); |
--p-border-width-2 should be replaced with --p-border-width-050 here.
sam-b-rose
added a commit
that referenced
this pull request
Sep 21, 2023
|
Addressed incorrect manual migrations here #10608 |
sam-b-rose
added a commit
that referenced
this pull request
Sep 21, 2023
sam-b-rose
added a commit
that referenced
this pull request
Sep 21, 2023
sam-b-rose
added a commit
that referenced
this pull request
Sep 21, 2023
sam-b-rose
added a commit
that referenced
this pull request
Sep 21, 2023
sam-b-rose
added a commit
that referenced
this pull request
Sep 21, 2023
sam-b-rose
added a commit
that referenced
this pull request
Sep 21, 2023
This reverts commit 7db26ac.
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Part of Shopify#10519 ### WHAT is this pull request doing? - Migrates the CSS custom properties for `border` token groups - Migrates the component props for `border` This the pre-v12 migration step to create a safe CSS custom property mapping to the new border tokens. <details> <summary>RegExp token search</summary> <pre><code>(?:--p-border-radius-1|--p-border-radius-1_5-experimental|--p-border-radius-2|--p-border-radius-3|--p-border-radius-4|--p-border-radius-5|--p-border-radius-6|--p-border-width-1|--p-border-width-1-experimental|--p-border-width-2|--p-border-width-2-experimental|--p-border-width-4)(?!\d)</code></pre> </details> ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
Thank you @lgriffee for catching these!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of #10519
WHAT is this pull request doing?
bordertoken groupsborderThis the pre-v12 migration step to create a safe CSS custom property mapping to the new border tokens.
RegExp token search
🎩 checklist
README.mdwith documentation changes