Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rename prop migration #10215

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Fix rename prop migration #10215

merged 4 commits into from
Aug 25, 2023

Conversation

aveline
Copy link
Contributor

@aveline aveline commented Aug 24, 2023

WHY are these changes introduced?

react-rename-component-prop migration was not working as expected when there were multiple props on a component

Screenshot 2023-08-24 at 10 12 10 AM

WHAT is this pull request doing?

  • Adds more test cases
  • Fixes migration
Screenshot 2023-08-24 at 10 12 35 AM

aveline and others added 3 commits August 24, 2023 10:13
@aveline @aaronccasanova
Add more test cases
82b3e2f 
Co-Authored-By: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
@aveline @aaronccasanova
Update node selection
bf23fe1 
Co-Authored-By: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
@aveline
Rename SubComponent to CompoundComponent
db2c4d5
kyledurand
kyledurand approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 👏

sam-b-rose
sam-b-rose approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@sam-b-rose sam-b-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Can you add a patch changeset for the migrations package? 🦋

@aveline aveline merged commit e4a6d47 into main Aug 25, 2023
10 checks passed
@aveline aveline deleted the fix-rename-prop-migration branch August 25, 2023 15:32
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Aug 25, 2023
Merged
sam-b-rose added a commit that referenced this pull request Aug 28, 2023
@sam-b-rose
Merge branch 'main' into update-next
8152b28 
* main:
  Fix rename prop migration (#10215)
  Update translations: default (#10219)
  [Avatar] Override SE23 background override with imageHasLoaded (#10211)
  Create Code style guide.md (#10176)
  ActionsList filtering (#9907)
  Version Packages (#10078)
  Support dynamic fontsizes in iOS devices (#10181)
  Fix migration resolution path (#10188)
  [Button] Deprecate connectedDisclosure  (#10183)
  Update sandbox.md (#10186)
  Allow migrator to target subcomponents and change prop values (#10071)
  Remove `polaris-cli` and `polaris-codemods` packages (#10101)
  Bump loader-utils from 1.4.0 to 1.4.2 (#7725)
  Bump deep-object-diff from 1.1.7 to 1.1.9 (#7734)
  Bump decode-uri-component from 0.2.0 to 0.2.2 (#7832)
  Bump webpack from 5.72.0 to 5.76.0 (#8667)
  Bump fastify from 4.5.3 to 4.15.0 (#8750)
  [Modal] Activator no longer wrapped in Box (#10086)
  Fix icon optimize config (#10087)
  [ResourceList] Remove layout jank when bulk actions enabled and item selected
sam-b-rose added a commit that referenced this pull request Aug 28, 2023
@sam-b-rose
Merge branch 'main' into update-next
56ee593 
* main:
  Fix rename prop migration (#10215)
  Update translations: default (#10219)
  [Avatar] Override SE23 background override with imageHasLoaded (#10211)
  Create Code style guide.md (#10176)
  ActionsList filtering (#9907)
  Version Packages (#10078)
  Support dynamic fontsizes in iOS devices (#10181)
  Fix migration resolution path (#10188)
  [Button] Deprecate connectedDisclosure  (#10183)
  Update sandbox.md (#10186)
  Allow migrator to target subcomponents and change prop values (#10071)
  Remove `polaris-cli` and `polaris-codemods` packages (#10101)
  Bump loader-utils from 1.4.0 to 1.4.2 (#7725)
  Bump deep-object-diff from 1.1.7 to 1.1.9 (#7734)
  Bump decode-uri-component from 0.2.0 to 0.2.2 (#7832)
  Bump webpack from 5.72.0 to 5.76.0 (#8667)
  Bump fastify from 4.5.3 to 4.15.0 (#8750)
  [Modal] Activator no longer wrapped in Box (#10086)
  Fix icon optimize config (#10087)
  [ResourceList] Remove layout jank when bulk actions enabled and item selected
kyledurand pushed a commit that referenced this pull request Aug 31, 2023
@shopify-github-actions-access @github-actions
Version Packages (#10204)
377a074 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-migrator@0.21.0

### Minor Changes

- [#10246](#10246)
[`1947b4691`](1947b46)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added the ability
to migrate prop values

### Patch Changes

- [#10215](#10215)
[`e4a6d47ab`](e4a6d47)
Thanks [@aveline](https://github.com/aveline)! - Fixed a bug in the
rename prop migration

## @shopify/polaris@11.14.0

### Minor Changes

- [#9907](#9907)
[`ef7ddb4ac`](ef7ddb4)
Thanks [@MaxCloutier](https://github.com/MaxCloutier)! - Add a search
field to filter ActionList that have more than 10 items

### Patch Changes

- [#10288](#10288)
[`cd1578230`](cd15782)
Thanks [@ssetem](https://github.com/ssetem)! - Only apply apple dynamic
text to mobile breakpoint


- [#10292](#10292)
[`72f55e32f`](72f55e3)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added check for
string type before calling string method


- [#10211](#10211)
[`ac044b3c9`](ac044b3)
Thanks [@peterlazzarino](https://github.com/peterlazzarino)! - Ensure
Avatar has no background color if an source prop is passed in to allow
for transparent images


- [#10287](#10287)
[`9b14e231a`](9b14e23)
Thanks [@laurkim](https://github.com/laurkim)! - Fixed focus ring and
input text styles on `ActionList.SearchField` component

## polaris.shopify.com@0.57.2

### Patch Changes

- Updated dependencies
\[[`ef7ddb4ac`](ef7ddb4),
[`cd1578230`](cd15782),
[`72f55e32f`](72f55e3),
[`ac044b3c9`](ac044b3),
[`9b14e231a`](9b14e23)]:
    -   @shopify/polaris@11.14.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
@aveline @aaronccasanova
Fix rename prop migration (Shopify#10215)
3d4ef92 
### WHY are these changes introduced?

`react-rename-component-prop` migration was not working as expected when
there were multiple props on a component

<img width="552" alt="Screenshot 2023-08-24 at 10 12 10 AM"
src="https://github.com/Shopify/polaris/assets/3474483/5ca5de71-f587-49cf-87ea-5fc73d298864">

### WHAT is this pull request doing?

- Adds more test cases
- Fixes migration

<img width="590" alt="Screenshot 2023-08-24 at 10 12 35 AM"
src="https://github.com/Shopify/polaris/assets/3474483/8dc1ee41-1900-4383-81e0-7635b2d2fa0b">

---------

Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyledurand kyledurand kyledurand approved these changes

@sam-b-rose sam-b-rose sam-b-rose approved these changes

@aaronccasanova aaronccasanova aaronccasanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aveline @kyledurand @sam-b-rose @aaronccasanova