Skip to content

Commit

Permalink
Remove polaris-cli and polaris-codemods packages (#10101)
Browse files Browse the repository at this point in the history
Use only the `@shopify/polaris-migrator` package.

This also removes the documentation for the Polaris CLI on the [Tools
page](https://polaris.shopify.com/tools/polaris-cli).

Removing these packages will

* **Improve our CI times** by removing extra packages from our build,
test, and lint workflows
* **Reduce confusion** on where to add new migrations or update previous
migrations
* **Clean up things** such as ESLint configs, changelog entries on
Version Package PRs, and package dep bumps
  • Loading branch information
sam-b-rose committed Aug 17, 2023
1 parent 3982ef9 commit e6a2d35
Show file tree
Hide file tree
Showing 361 changed files with 433 additions and 14,014 deletions.
11 changes: 11 additions & 0 deletions .changeset/friendly-bananas-crash.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
'@shopify/polaris-migrator': minor
---

Removed the `@shopify/polaris-cli` and `@shopify/polaris-codemods` package in favor of using only the `@shopify/polaris-migrator`.

Removing these packages will provide the following benefits:

- Improve CI time by removing extra packages from our build, test, and lint workflows
- Reduce confusion on where to add new migrations or update previous migrations
- Clean up ESLint configs, reduce changelog entries, and remove package dependencies
23 changes: 0 additions & 23 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,29 +98,6 @@ module.exports = {
},
overrides: [
...packages.map((packageDir) => noExtraneousDependenciesConfig(packageDir)),
{
files: ['polaris-cli/src/**/*.{ts,tsx}'],
rules: {
'import/no-default-export': 'off',
},
},
{
files: ['polaris-codemods/src/**/*.{ts,tsx}'],
rules: {
'import/no-default-export': 'off',
// Issue with inconsistent import order between node 14 and 16.
// This could be removed after dropping node 14 support.
'import/order': 'off',
},
},
{
files: ['polaris-codemods/src/**/tests/*.{ts,tsx}'],
rules: {
'import/no-extraneous-dependencies': 'off',
'@shopify/jsx-no-hardcoded-content': 'off',
'@typescript-eslint/ban-ts-comment': 'off',
},
},
{
files: ['polaris-migrator/src/**/*.{ts,tsx}'],
rules: {
Expand Down
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
},
"workspaces": {
"packages": [
"polaris-cli",
"polaris-codemods",
"polaris-tokens",
"polaris-for-vscode",
"polaris-icons",
Expand Down
Loading

0 comments on commit e6a2d35

Please sign in to comment.