Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 #95: Replace whitespaces to plus-sign to handle url-encoded hrefs #96

Merged
merged 1 commit into from
Sep 25, 2024
Merged

🐛 #95: Replace whitespaces to plus-sign to handle url-encoded hrefs #96

merged 1 commit into from
Sep 25, 2024

Conversation

Sharp0802
Copy link
Owner

Target

  • HRefs use url-encoded path for posts - whose whitespaces( ) are replaced with plus-sign(+)
  • But, because file-system-writer does nothing to encode paths, %20 is required, not plus-sign(+).

Patches

  • Replace whitespace to plus-sign when writing to file-system

See also #95

@Sharp0802 Sharp0802 added the bug Something isn't working label Sep 25, 2024
@Sharp0802 Sharp0802 self-assigned this Sep 25, 2024
@Sharp0802 Sharp0802 linked an issue Sep 25, 2024 that may be closed by this pull request
Mis-replaced whitespaces in hrefs #95
Closed
@Sharp0802
Copy link
Owner Author

Tested ACK

@Sharp0802 Sharp0802 merged commit 335a388 into master Sep 25, 2024
2 checks passed
@Sharp0802 Sharp0802 deleted the #95 branch September 25, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Sharp0802 Sharp0802

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mis-replaced whitespaces in hrefs
1 participant
@Sharp0802