Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSS Validation Workflow #20

Merged
merged 5 commits into from
May 9, 2022
Merged

Add CSS Validation Workflow #20

merged 5 commits into from
May 9, 2022

Conversation

nok-ko
Copy link
Collaborator

@nok-ko nok-ko commented May 9, 2022

What This PR Does

  • Adds a CSS Validation GitHub workflow – every commit will be validated for CSS errors using the csstree-validator Node package.

Why This Is Good

  • Adds confidence that we haven't seriously mucked up any CSS, hopefully avoiding Arron's wrath.

Why This Might Be Bad

  • Adds extra spam to the already pretty high traffic #commit-log channel in our team Discord.
    • I can make the commit bot not report action runs if the spam is too much to bear.
  • Based on a semi-janky custom GitHub Action (see nok-ko/validate-css-action)

@nok-ko nok-ko marked this pull request as draft May 9, 2022 05:07
@nok-ko
Copy link
Collaborator Author

nok-ko commented May 9, 2022

Whoop. Converting PR to draft, gotta clean up some extraneous stuff in the repo – forgot about that. Low-priority work for myself, for tomorrow.

@nok-ko
Copy link
Collaborator Author

nok-ko commented May 9, 2022

Add a CSS Validation GitHub Action (Est. 1hr, actual 3hr)

@nok-ko
Copy link
Collaborator Author

nok-ko commented May 9, 2022

Bot should no longer spam the #commit-log channel!

Ready for review.

@nok-ko nok-ko marked this pull request as ready for review May 9, 2022 21:57
@nok-ko nok-ko self-assigned this May 9, 2022
@nok-ko nok-ko requested review from AlexLLKong and ArtfulJW May 9, 2022 21:57
@nok-ko nok-ko merged commit e55bed5 into dev May 9, 2022
@nok-ko nok-ko mentioned this pull request May 12, 2022
Open
6 tasks
nok-ko added a commit that referenced this pull request May 20, 2022
@nok-ko
Merge pull request #20 from ShakeGuard/Katy_Add_CSS_CI
7c66007 
Add a CSS Validation Workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexLLKong AlexLLKong AlexLLKong approved these changes

@ArtfulJW ArtfulJW Awaiting requested review from ArtfulJW

Assignees

@nok-ko nok-ko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nok-ko @AlexLLKong