Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependecy upgrade february #1214

Merged
merged 9 commits into from
Mar 3, 2021
Merged

Conversation

enikonemeth
Copy link
Contributor

@enikonemeth enikonemeth commented Feb 24, 2021

SKIPPED PACKAGES

NOTE

Don't delete the yarn.lock and generate it again cause one of our dependency will use the new version of typescript
which is incompatible with eslint and prettier

Webpack has been updated to v5.x. Please check the configs twice before we merge it to develop!
migration guide: https://webpack.js.org/migrate/5/

@enikonemeth enikonemeth added this to the Sprint 230 milestone Feb 24, 2021
@enikonemeth enikonemeth self-assigned this Feb 24, 2021
@sensenet
Copy link

sensenet bot commented Feb 24, 2021

Site name Url Last deploy
sn-app-dev https://603fbaed35597a7a1bc40d53--sn-app-dev.netlify.app Wed Mar 03 2021 - 16:35:58 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://603fbae335597a7c50c40dc0--sn-react-component-docs-dev.netlify.app Wed Mar 03 2021 - 16:35:48 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #1214 (88139aa) into develop (1039ab2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1214   +/-   ##
========================================
  Coverage    93.76%   93.76%           
========================================
  Files          232      232           
  Lines         6578     6578           
  Branches      1681     1682    +1     
========================================
  Hits          6168     6168           
  Misses         410      410           
Impacted Files Coverage Δ
...eact/src/Components/Fields/ReferenceFieldInput.tsx 85.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1039ab2...88139aa. Read the comment docs.

@herflis herflis modified the milestones: Sprint 230, Sprint 231 Mar 3, 2021
Copy link
Contributor

@taki9 taki9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using [hash] placeholder in webpack configuration, consider changing it to [contenthash]. It is not the same, but proven to be more effective.

search for [hash:8] on the project and replace it with [contenthash:8]

@enikonemeth enikonemeth requested a review from taki9 March 3, 2021 13:54
@enikonemeth enikonemeth merged commit 0f9c4da into develop Mar 3, 2021
@enikonemeth enikonemeth deleted the feature/dep_upgrade_february branch March 3, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants