Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove usages of lodash/fp in customPropTypes #4073

Merged
merged 4 commits into from
Sep 28, 2020

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Sep 28, 2020

This PR removes the last usage of lodash/fp in distributed code, this will not improve anything as customPropTypes are not bundled into production builds. The change is done to unblock #4072.

customPropTypes.some() was removed as it can be replaced with PropTypes.oneOfType().

@github-actions
Copy link

size-limit report

Path Size
bundle-size/dist/Button.size.js 66.46 KB (0%)
bundle-size/dist/Icon.size.js 30.65 KB (0%)
bundle-size/dist/Image.size.js 61.7 KB (0%)
bundle-size/dist/Modal.size.js 76.72 KB (0%)
bundle-size/dist/Portal.size.js 47.78 KB (0%)

@codecov-commenter
Copy link

Codecov Report

Merging #4073 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4073   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         183      183           
  Lines        3280     3280           
=======================================
  Hits         3275     3275           
  Misses          5        5           
Impacted Files Coverage Δ
src/collections/Form/FormField.js 100.00% <ø> (ø)
src/elements/Button/Button.js 95.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f6e64...c03037a. Read the comment docs.

@layershifter layershifter merged commit 26daf99 into master Sep 28, 2020
@layershifter layershifter deleted the chore/omit-lodash-fp branch September 28, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants