Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(MountNode): deprecate component #4027

Merged
merged 7 commits into from
Aug 10, 2020
Merged

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Aug 10, 2020

⚠️ Deprecation

This PR marks MountNode as deprecated, we will remove it in the next major release, i.e. 2.0.0.


The MountNode component was originally introduced in #2407. The main issue that is component should not be a part of the public API as it solves our specific issue with the Modal component.

This PR internally replaces usages of MountNode with useClassNamesOnNode() hook. The refactored version of utils does not use either lodash or lodash/fp, this allows to cut almost 30KB from bundled code 🎉


This component will not be longer exported in V2.

If you are using this functionality, please make a follow up in this PR and we will export useClassNamesOnNode().

@github-actions
Copy link

github-actions bot commented Aug 10, 2020

size-limit report

Path Size
bundle-size/dist/Button.size.js 67.39 KB (+0.01% 🔺)
bundle-size/dist/Icon.size.js 30.58 KB (+0.01% 🔺)
bundle-size/dist/Image.size.js 62.64 KB (+0.01% 🔺)
bundle-size/dist/Modal.size.js 77.74 KB (-35.43% 🔽)
bundle-size/dist/Portal.size.js 48.75 KB (0%)

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2020

Codecov Report

Merging #4027 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4027   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         186      183    -3     
  Lines        3255     3275   +20     
=======================================
+ Hits         3250     3270   +20     
  Misses          5        5           
Impacted Files Coverage Δ
src/addons/MountNode/MountNode.js 100.00% <100.00%> (ø)
src/lib/hooks/useClassNamesOnNode.js 100.00% <100.00%> (ø)
src/lib/hooks/useIsomorphicLayoutEffect.js 100.00% <100.00%> (ø)
src/modules/Modal/ModalDimmer.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffaf2c1...0608c3c. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview August 10, 2020 14:07 Inactive
@vercel vercel bot temporarily deployed to Preview August 10, 2020 14:09 Inactive
@vercel vercel bot temporarily deployed to Preview August 10, 2020 14:09 Inactive
@vercel vercel bot temporarily deployed to Preview August 10, 2020 14:20 Inactive
@layershifter layershifter changed the title chore(MountNode): deprecate component [WIP] chore(MountNode): deprecate component Aug 10, 2020
@vercel vercel bot temporarily deployed to Preview August 10, 2020 14:25 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants