Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve bundle size #4011

Merged
merged 2 commits into from
Jul 31, 2020
Merged

chore: improve bundle size #4011

merged 2 commits into from
Jul 31, 2020

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jul 30, 2020

This PR improves package's bundle size:

@github-actions
Copy link

github-actions bot commented Jul 30, 2020

size-limit report

Path Size
bundle-size/dist/Button.size.js 67.39 KB (-5.13% 🔽)
bundle-size/dist/Icon.size.js 30.58 KB (-9.27% 🔽)
bundle-size/dist/Image.size.js 62.64 KB (-5.57% 🔽)
bundle-size/dist/Modal.size.js 104.82 KB (-3.64% 🔽)
bundle-size/dist/Portal.size.js 48.75 KB (-2.37% 🔽)

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2020

Codecov Report

Merging #4011 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4011   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         185      185           
  Lines        3251     3251           
=======================================
  Hits         3246     3246           
  Misses          5        5           
Impacted Files Coverage Δ
src/collections/Breadcrumb/Breadcrumb.js 100.00% <ø> (ø)
src/collections/Breadcrumb/BreadcrumbDivider.js 100.00% <ø> (ø)
src/collections/Breadcrumb/BreadcrumbSection.js 100.00% <ø> (ø)
src/collections/Form/Form.js 100.00% <ø> (ø)
src/collections/Form/FormField.js 100.00% <ø> (ø)
src/collections/Form/FormGroup.js 100.00% <ø> (ø)
src/collections/Grid/Grid.js 100.00% <ø> (ø)
src/collections/Grid/GridColumn.js 100.00% <ø> (ø)
src/collections/Grid/GridRow.js 100.00% <ø> (ø)
src/collections/Menu/Menu.js 100.00% <ø> (ø)
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5230cd3...0fbaf1b. Read the comment docs.

@vercel vercel bot requested a deployment to Preview July 31, 2020 11:26 Abandoned
@layershifter layershifter changed the title chore: improve bundle size [WIP] chore: improve bundle size Jul 31, 2020
@layershifter layershifter merged commit 694e399 into master Jul 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the chore/bundle-size-improve branch July 31, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants