-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(SidebarExampleTransitions): fix look of the example #3997
Conversation
@@ -17,6 +17,12 @@ | |||
"rules": { | |||
"no-restricted-imports": "off" | |||
} | |||
}, | |||
{ | |||
"files": ["**/*Example*.js"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The requirement to have propTypes
in examples is really annoying...
} | ||
|
||
export default class SidebarExampleTransitions extends Component { | ||
state = { | ||
function SidebarExampleTransitions() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also moved to be functional component
Codecov Report
@@ Coverage Diff @@
## master #3997 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 183 183
Lines 3157 3157
=======================================
Hits 3152 3152
Misses 5 5 Continue to review full report at Codecov.
|
Fixes #3884.