Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): correct webpack example link #3898

Merged
merged 3 commits into from
Jul 27, 2020

Conversation

snitin315
Copy link
Contributor

Fixes #3897

@welcome
Copy link

welcome bot commented Feb 10, 2020

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

Codecov Report

Merging #3898 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3898   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         178      178           
  Lines        3150     3150           
=======================================
  Hits         3145     3145           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dbab6b...3e03e6e. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2020

Codecov Report

Merging #3898 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3898   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         183      183           
  Lines        3157     3157           
=======================================
  Hits         3152     3152           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0335ce5...01cc05e. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview July 27, 2020 11:51 Inactive
@snitin315 snitin315 changed the title fix: correct webpack example link in README.md docs(README): correct webpack example link Jul 27, 2020
### [webpack][28]
See our webpack 3 example project [here][28] (includes theming).

### [SUIcrux][102]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The project is not maintained anymore.

@@ -85,13 +85,7 @@ This is a listing of example projects and guides that will help you integrate Se

<details>
<summary>Show projects</summary>

### [webpack][28]
See our webpack 3 example project [here][28] (includes theming).
Copy link
Member

@layershifter layershifter Jul 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this link should be removed at all as these examples were removed at all (#3729).

@layershifter layershifter merged commit 7889c7a into Semantic-Org:master Jul 27, 2020
@welcome
Copy link

welcome bot commented Jul 27, 2020

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@snitin315
Copy link
Contributor Author

@layershifter How can I become member of Semantic-UI org on GitHub?

@layershifter
Copy link
Member

@snitin315 we don't have a policy around the membership and actually I don't control it 🤔

Others did significant impact on SUIR at some point, so contributions are the best option to become a member I would say...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README: Invalid link for webpack under example projects
5 participants