Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make get started instructions around themes more clear #3713

Merged
merged 7 commits into from
Jul 28, 2020

Conversation

justsml
Copy link
Contributor

@justsml justsml commented Jul 21, 2019

I think this looks good. Just did a casual check, was hoping I could get more eyes on it.

Thanks in advance ❤️

@welcome
Copy link

welcome bot commented Jul 21, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented Jul 21, 2019

Codecov Report

Merging #3713 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3713      +/-   ##
==========================================
- Coverage   99.84%   99.83%   -0.01%     
==========================================
  Files         178      175       -3     
  Lines        3150     3120      -30     
==========================================
- Hits         3145     3115      -30     
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Popup/Popup.js 98.68% <0%> (-0.04%) ⬇️
src/modules/Transition/TransitionGroup.js 100% <0%> (ø) ⬆️
src/collections/Form/FormTextArea.js 100% <0%> (ø) ⬆️
src/collections/Form/FormRadio.js 100% <0%> (ø) ⬆️
src/modules/Checkbox/Checkbox.js 100% <0%> (ø) ⬆️
src/modules/Sidebar/Sidebar.js 100% <0%> (ø) ⬆️
src/collections/Form/FormInput.js 100% <0%> (ø) ⬆️
src/collections/Form/FormDropdown.js 100% <0%> (ø) ⬆️
src/collections/Form/FormField.js 100% <0%> (ø) ⬆️
src/modules/Dropdown/DropdownItem.js 100% <0%> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dbab6b...0d2fad7. Read the comment docs.

@levithomason
Copy link
Member

I really like the split here in explanations 👍 Keep it coming.

@justsml justsml marked this pull request as ready for review December 14, 2019 02:13
@justsml justsml changed the title WIP: Making setup instructions around themes more clear Making setup instructions around themes more clear Dec 14, 2019
@justsml
Copy link
Contributor Author

justsml commented Dec 14, 2019

Hi @levithomason let me know if you want to see anything else added/changed.

I'm happy to jump on it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2020

Codecov Report

Merging #3713 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3713   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         184      184           
  Lines        3218     3218           
=======================================
  Hits         3213     3213           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 358d142...25dc424. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview July 28, 2020 11:56 Inactive
@layershifter layershifter changed the title Making setup instructions around themes more clear docs: make get started instructions around themes more clear Jul 28, 2020
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simplified markup a bit, LGTM 👍

@welcome
Copy link

welcome bot commented Jul 28, 2020

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants