Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Checkbox): handle change on root element #3693

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jul 7, 2019

Fixes #3502.

In SUI the whole area of slider is clickable, previously we had an behavior mismatch. This PR fixes it.

Before

before

After

after

@codecov-io
Copy link

Codecov Report

Merging #3693 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3693      +/-   ##
==========================================
+ Coverage   99.83%   99.83%   +<.01%     
==========================================
  Files         175      175              
  Lines        3116     3120       +4     
==========================================
+ Hits         3111     3115       +4     
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Checkbox/Checkbox.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 905917a...62b4471. Read the comment docs.

@felixmosh
Copy link
Contributor

I'm not sure that the solution is good, I think that what can be fixed using css is better, but it is your decision.
Thanx for the fix!

@layershifter
Copy link
Member Author

I think that what can be fixed using css is better, but it is your decision.

I can agree with it, but we should match SUI behavior 😺

@layershifter layershifter merged commit d288b4e into master Jul 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/checkbox-slider branch July 8, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox: slider is not clickable in the entire area
3 participants