fix(Checkbox): handle click properly on label #3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Jul 7, 2019
| @@ -148,8 +148,9 @@ export default class Checkbox extends Component { | |||
| const { id } = this.props | |||
| const { checked, indeterminate } = this.state | |||
|
|
|||
| const isLabelClick = _.invoke(this.labelRef.current, 'contains', e.target) | |||
There was a problem hiding this comment.
Previously there was an equality comparison, but in this case contains() should be used.
Codecov Report
@@ Coverage Diff @@
## master #3692 +/- ##
=======================================
Coverage 99.83% 99.83%
=======================================
Files 175 175
Lines 3116 3116
=======================================
Hits 3111 3111
Misses 5 5
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3692 +/- ##
=======================================
Coverage 99.83% 99.83%
=======================================
Files 175 175
Lines 3116 3116
=======================================
Hits 3111 3111
Misses 5 5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3683.