Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Search): custom category layout renderer #3672

Conversation

PrincessMadMath
Copy link
Contributor

POC for: #3630

@welcome
Copy link

welcome bot commented Jun 18, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented Jul 19, 2019

Codecov Report

Merging #3672 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3672      +/-   ##
==========================================
- Coverage   99.84%   99.82%   -0.03%     
==========================================
  Files         177      180       +3     
  Lines        3145     2792     -353     
==========================================
- Hits         3140     2787     -353     
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Search/Search.js 99.46% <100%> (-0.09%) ⬇️
src/modules/Search/SearchCategory.js 100% <100%> (ø) ⬆️
src/modules/Search/SearchCategoryLayout.js 100% <100%> (ø)
src/elements/Button/Button.js 94.28% <0%> (-1.17%) ⬇️
src/modules/Popup/Popup.js 98.24% <0%> (-0.48%) ⬇️
src/modules/Sticky/Sticky.js 98.91% <0%> (-0.18%) ⬇️
src/modules/Transition/TransitionGroup.js 100% <0%> (ø) ⬆️
src/collections/Form/FormTextArea.js 100% <0%> (ø) ⬆️
src/addons/Pagination/Pagination.js 100% <0%> (ø) ⬆️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d46f9...7109d55. Read the comment docs.

@patricklafrance
Copy link

Hey @layershifter!

We would love to hear your feedback on this PR. This is a customization we have been looking for for a while!

Thank you,

Patrick

@@ -21,7 +21,7 @@ const SearchTypesExamples = () => (
examplePath='modules/Search/Types/SearchExampleCategory'
/>
<ComponentExample
title='Category (Custom Render)'
title='Category (Custom Render) v2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not version the example titles in this way. It will be confusing with the semver already in place.

@levithomason
Copy link
Member

This is really fantastic, thanks for the great work. I'll get this merged and shipped.

@levithomason levithomason changed the title Feat/3630 custom search category renderer feat(Search): custom search category layout renderer Dec 8, 2019
@levithomason levithomason changed the title feat(Search): custom search category layout renderer feat(Search): custom category layout renderer Dec 8, 2019
@levithomason levithomason merged commit 071f918 into Semantic-Org:master Dec 8, 2019
@welcome
Copy link

welcome bot commented Dec 8, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants