Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(layouts): fix incorrectly cased tabIndex in Bootstrap layout #3668

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

AaronCTech
Copy link
Contributor

The tabIndex prop was passed as tabindex (non camel-cased).

Simple and quick change :)

The tabIndex prop was passed as tabindex (non camel-cased).

Simple and quick change :)
@welcome
Copy link

welcome bot commented Jun 17, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

Codecov Report

Merging #3668 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3668   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files         174      174           
  Lines        2755     2755           
=======================================
  Hits         2750     2750           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44ce3d0...1a630bb. Read the comment docs.

@layershifter layershifter changed the title Correct incorrectly cased tabIndex: Bootstrap L/O docs(layouts): fix incorrectly cased tabIndex in Bootstrap layout Jun 17, 2019
@layershifter layershifter merged commit 00659bd into Semantic-Org:master Jun 17, 2019
@welcome
Copy link

welcome bot commented Jun 17, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants