Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(Modal): reduce unnecessary layout invalidations #3609

Merged
merged 2 commits into from
May 26, 2019

Conversation

HighCoordination
Copy link
Contributor

Improve performance especially in IE11 when a modal is used

Improve performance especially in IE11 when a modal is used
@welcome
Copy link

welcome bot commented May 14, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented May 14, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@30d93a3). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3609   +/-   ##
=========================================
  Coverage          ?   99.81%           
=========================================
  Files             ?      174           
  Lines             ?     2745           
  Branches          ?        0           
=========================================
  Hits              ?     2740           
  Misses            ?        5           
  Partials          ?        0
Impacted Files Coverage Δ
src/modules/Modal/Modal.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30d93a3...6b42202. Read the comment docs.

@layershifter layershifter merged commit 5ae8576 into Semantic-Org:master May 26, 2019
@welcome
Copy link

welcome bot commented May 26, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

mbakiev pushed a commit to mbakiev/Semantic-UI-React that referenced this pull request Jun 17, 2019
Improve performance especially in IE11 when a modal is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants