Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Shorthand|Theming): rework docs to be more actual #3564

Merged
merged 3 commits into from
Apr 15, 2019

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Apr 11, 2019

Fixes #561.

This PR reworks and adds more information about APIs and theming 🥇

Augmentation

Fully new docs page that covers as prop usage 👍

Theming

Added fully new guide about theming in Create React App :atom:

Shorthand

Docs for shorthand props, very detailed 🎉 Thanks to Stardust team for them 👍

@layershifter
Copy link
Member Author

/cc @brianespinosa you may be interested 🐰

@codecov-io
Copy link

codecov-io commented Apr 11, 2019

Codecov Report

Merging #3564 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3564   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files         174      174           
  Lines        2730     2730           
=======================================
  Hits         2725     2725           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c532f72...4f91357. Read the comment docs.

@layershifter layershifter merged commit 3067f5a into master Apr 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the docs/theming branch April 15, 2019 11:25
@brianespinosa
Copy link
Member

Thanks @layershifter! You're awesome.

I've had almost zero time for open source the past few months. Thanks for keeping things going.

mbakiev pushed a commit to mbakiev/Semantic-UI-React that referenced this pull request Jun 17, 2019
…3564)

* docs(Shorthand|Theming): rework docs to be more actual

* remove extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(shorthand): add dedicated shorthand docs page
3 participants