Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Card): fix image shorthand #3551

Merged
merged 2 commits into from
Apr 8, 2019
Merged

fix(Card): fix image shorthand #3551

merged 2 commits into from
Apr 8, 2019

Conversation

layershifter
Copy link
Member

Fixes #3542.

Updates generated markup by shorthand.

Before

<img src="..." class="ui image" />

image

After

<div class="image">
  <img src="..." />
</div>

image

@codecov-io
Copy link

codecov-io commented Apr 3, 2019

Codecov Report

Merging #3551 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3551   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files         174      174           
  Lines        2725     2725           
=======================================
  Hits         2720     2720           
  Misses          5        5
Impacted Files Coverage Δ
src/views/Card/Card.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d26779...c83ebb0. Read the comment docs.

@layershifter layershifter merged commit ca81dd8 into master Apr 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/card-image branch April 8, 2019 13:40
mbakiev pushed a commit to mbakiev/Semantic-UI-React that referenced this pull request Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants