Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): remove component page hash replacement #3528

Merged
merged 5 commits into from
Mar 22, 2019
Merged

fix(docs): remove component page hash replacement #3528

merged 5 commits into from
Mar 22, 2019

Conversation

GreenTeaCake
Copy link
Contributor

@GreenTeaCake GreenTeaCake commented Mar 20, 2019

Closes #3527 and affects #2732 (removes componentWillMount from ComponentDoc).

@welcome
Copy link

welcome bot commented Mar 20, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented Mar 21, 2019

Codecov Report

Merging #3528 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3528   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         172      172           
  Lines        2795     2795           
=======================================
  Hits         2790     2790           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db04da...60074ca. Read the comment docs.

@layershifter layershifter changed the title fix(docs): Component page hash replacement. fix(docs): remove component page hash replacement Mar 21, 2019
@layershifter
Copy link
Member

@grumblerchester thanks for pushing this. It's weird, I removed this part of code and it still works 🦀 Can you please confirm?

@GreenTeaCake
Copy link
Contributor Author

@layershifter Yeah! Deletion resolves the issue too and everything works absolutely fine for old hashes.
But I'm not sure what "hash replacement for new hashes" is supposed to do. 🤢

@layershifter
Copy link
Member

Can you please clarify what is "old" and "new" hashes?

@GreenTeaCake
Copy link
Contributor Author

@layershifter Please see isOldHash that is used by getFormattedHash.
I have an assumption that these terms were introduced during some migration but not sure if the migration is completed.

@layershifter
Copy link
Member

layershifter commented Mar 22, 2019

I see, yep it was introduced in #2760 to fix #2737.

Actually, it was year ago and I don't see there a big issue that some of extra old links can be broken as they will still point to the correct page.

@layershifter layershifter merged commit fbef399 into Semantic-Org:master Mar 22, 2019
@GreenTeaCake GreenTeaCake deleted the fix-hash-replacement branch March 22, 2019 16:58
mbakiev pushed a commit to mbakiev/Semantic-UI-React that referenced this pull request Jun 17, 2019
* fix(docs): Component page hash replacement.

* Update ComponentDoc.js

* Update ComponentDoc.js

* Update ComponentDoc.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants