Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Sticky): preserve item height #3500

Merged
merged 4 commits into from
Mar 20, 2019
Merged

Conversation

felixmosh
Copy link
Contributor

@felixmosh felixmosh commented Mar 13, 2019

This PR fixes #3499

@welcome
Copy link

welcome bot commented Mar 13, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #3500 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3500      +/-   ##
==========================================
+ Coverage   99.82%   99.82%   +<.01%     
==========================================
  Files         172      172              
  Lines        2794     2795       +1     
==========================================
+ Hits         2789     2790       +1     
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Sticky/Sticky.js 98.91% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aff7ea...3e3117e. Read the comment docs.

@felixmosh
Copy link
Contributor Author

Any update regarding this PR?

@layershifter layershifter changed the title Preserve sticky item height fixes(3499) fix(Sticky): preserve item height Mar 20, 2019
@layershifter layershifter merged commit 6eefe00 into Semantic-Org:master Mar 20, 2019
@welcome
Copy link

welcome bot commented Mar 20, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@layershifter
Copy link
Member

@felixmosh sorry for delay, thank you ❤️

mbakiev pushed a commit to mbakiev/Semantic-UI-React that referenced this pull request Jun 17, 2019
* Preserve sticky item height fixes(3499)

* Add above content example

* Update StickyExampleAboveContent.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sticky component not preserves the height of the container
3 participants