Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): not calls onChange when value is not changed on item click #3482

Conversation

jongsue
Copy link
Contributor

@jongsue jongsue commented Mar 8, 2019

fixes #3437

@codecov-io
Copy link

codecov-io commented Mar 8, 2019

Codecov Report

Merging #3482 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3482      +/-   ##
==========================================
+ Coverage   99.82%   99.82%   +<.01%     
==========================================
  Files         172      172              
  Lines        2802     2805       +3     
==========================================
+ Hits         2797     2800       +3     
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d078aa...cfff8ee. Read the comment docs.

@layershifter layershifter merged commit 25e382e into Semantic-Org:master Mar 12, 2019
@levithomason
Copy link
Member

Released in semantic-ui-react@0.86.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: calls onChange even when value is not changed
4 participants