Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Modal): fix Modal.Description description #3450

Merged
merged 1 commit into from
Feb 22, 2019
Merged

docs(Modal): fix Modal.Description description #3450

merged 1 commit into from
Feb 22, 2019

Conversation

hollg
Copy link
Contributor

@hollg hollg commented Feb 22, 2019

Change description of Modal.Description from "A modal can have a header" to "A modal can contain a description with one or more paragraphs", which is consistent with Card.Description's docs

Change description of Modal.Description from "A modal can have a header" to "A modal can contain a description with one or more paragraphs", which is consistent with Card.Description's docs
@welcome
Copy link

welcome bot commented Feb 22, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

Codecov Report

Merging #3450 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3450   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files         172      172           
  Lines        2829     2829           
=======================================
  Hits         2826     2826           
  Misses          3        3
Impacted Files Coverage Δ
src/modules/Modal/ModalDescription.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527863b...d092713. Read the comment docs.

@layershifter layershifter changed the title docs (Modal.Description): fix Modal.Description description docs(Modal): fix Modal.Description description Feb 22, 2019
@layershifter layershifter merged commit ddbf43d into Semantic-Org:master Feb 22, 2019
@welcome
Copy link

welcome bot commented Feb 22, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@levithomason
Copy link
Member

Released in semantic-ui-react@0.86.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants