Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Icon): update typings for corner prop #3393

Merged
merged 2 commits into from
Jan 22, 2019

Conversation

areading314
Copy link
Contributor

@welcome
Copy link

welcome bot commented Jan 20, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented Jan 20, 2019

Codecov Report

Merging #3393 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3393   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files         170      170           
  Lines        2809     2809           
=======================================
  Hits         2806     2806           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d363d34...7733642. Read the comment docs.

@layershifter layershifter changed the title Corner prop can be a string, not just boolean fix(Icon): update typings for corner prop Jan 22, 2019
@layershifter layershifter merged commit f2c39cb into Semantic-Org:master Jan 22, 2019
@welcome
Copy link

welcome bot commented Jan 22, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@layershifter
Copy link
Member

Thanks much, missed this in #3315 👍

@levithomason
Copy link
Member

Released in semantic-ui-react@0.85.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants