chore(package): upgrade keyboard-key #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3390 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 170 170
Lines 2809 2809
=======================================
Hits 2806 2806
Misses 3 3Continue to review full report at Codecov.
|
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3251
The latest release of
keyboard-keynow respects event objects that already have akeyproperty. This should resolve many bugs like what was noted in the linked issue.The long term fix there is to add locale support to keyboard-key. Namely, we'd need to handle the proper shift values for every keyboard locale. See the new Locale Caveat section over at
keyboard-key.