Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popup): add disabled prop #3377

Merged
merged 7 commits into from
Jan 23, 2019

Conversation

husseyexplores
Copy link
Contributor

@husseyexplores husseyexplores commented Jan 12, 2019

Fixes: #3339

Let me know if something is missing from this.

@welcome
Copy link

welcome bot commented Jan 12, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented Jan 12, 2019

Codecov Report

Merging #3377 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3377   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files         170      170           
  Lines        2809     2809           
=======================================
  Hits         2806     2806           
  Misses          3        3
Impacted Files Coverage Δ
src/modules/Popup/Popup.js 99.23% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c39cb...515424d. Read the comment docs.

Copy link
Member

@levithomason levithomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, let's just add a doc site example. See my comment.

src/modules/Popup/Popup.d.ts Outdated Show resolved Hide resolved
@layershifter layershifter changed the title feat(Popup): disabled prop disables Popup feat(Popup): add disabled prop Jan 23, 2019
@layershifter layershifter merged commit 211c3d6 into Semantic-Org:master Jan 23, 2019
@welcome
Copy link

welcome bot commented Jan 23, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@husseyexplores husseyexplores deleted the popup-disable-prop branch January 23, 2019 14:03
@levithomason
Copy link
Member

Released in semantic-ui-react@0.85.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants