Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): drop DLL stage #3324

Merged
merged 3 commits into from
Jan 9, 2019
Merged

chore(build): drop DLL stage #3324

merged 3 commits into from
Jan 9, 2019

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Dec 5, 2018

This PR removes dll stage of build because it doesn't provide any performance benefits and massively simplifies webpack's config. Build time was reduced from 01:36 to 01:25.

@codecov-io
Copy link

codecov-io commented Dec 5, 2018

Codecov Report

Merging #3324 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3324   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files         170      170           
  Lines        2812     2812           
=======================================
  Hits         2809     2809           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2598403...fcde501. Read the comment docs.

@layershifter layershifter added chore wip Work in progress labels Dec 10, 2018
@layershifter layershifter changed the title [WIP] chore(build): drop DLL stage chore(build): drop DLL stage Jan 9, 2019
@layershifter layershifter removed the wip Work in progress label Jan 9, 2019
@layershifter layershifter merged commit a5a1e6e into master Jan 9, 2019
@layershifter layershifter deleted the chore/drop-dll branch January 9, 2019 12:32
@levithomason
Copy link
Member

Released in semantic-ui-react@0.85.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants