Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Dimmer): use createRef() API and componentDidUpdate() #3320

Merged
merged 4 commits into from
Dec 5, 2018

Conversation

layershifter
Copy link
Member

Refs #2732.

This PR:

  • replaces componentWillReceiveProps() with componentDidUpdate()
  • replaces functional refs with createRef() API

@codecov-io
Copy link

Codecov Report

Merging #3320 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3320   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files         170      170           
  Lines        2801     2801           
=======================================
  Hits         2798     2798           
  Misses          3        3
Impacted Files Coverage Δ
src/modules/Dimmer/DimmerInner.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22fe8ed...122aa0f. Read the comment docs.

@layershifter layershifter merged commit 93c918b into master Dec 5, 2018
@layershifter layershifter deleted the chore/dimmer-new-apis branch December 10, 2018 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants