Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): remove redundant role attribute #3272

Merged
merged 5 commits into from
Nov 22, 2018
Merged

fix(Button): remove redundant role attribute #3272

merged 5 commits into from
Nov 22, 2018

Conversation

floppyvlaDISK
Copy link
Contributor

Fixes #3262.

@welcome
Copy link

welcome bot commented Nov 11, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented Nov 11, 2018

Codecov Report

Merging #3272 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3272      +/-   ##
==========================================
+ Coverage   99.92%   99.92%   +<.01%     
==========================================
  Files         169      169              
  Lines        2803     2807       +4     
==========================================
+ Hits         2801     2805       +4     
  Misses          2        2
Impacted Files Coverage Δ
src/elements/Button/Button.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c19023...bb8e0eb. Read the comment docs.

@layershifter layershifter changed the title fix(Button): fix redundant role attribute (#3262) fix(Button): remove redundant role attribute Nov 22, 2018
@layershifter layershifter merged commit e6584ff into Semantic-Org:master Nov 22, 2018
@welcome
Copy link

welcome bot commented Nov 22, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@floppyvlaDISK floppyvlaDISK deleted the fix-3262 branch November 22, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants